Ticket 1307 #447
Ticket 1307 #447
Conversation
src/allmydata/web/common.py
Outdated
| from allmydata import __version__ | ||
| req = IRequest(ctx) | ||
| req.setHeader("server", "Tahoe-LAFS gateway v" + __version__) | ||
| methods = ', '.join([m[7:] for m in dir(self) if m.startswith('render_')]) |
There was a problem hiding this comment.
Do we do this other places? I kind of think maybe we shouldn't stick the exact version in there (e.g. just "Tahoe-LAFS gateway")
There was a problem hiding this comment.
Not that I am aware of. I removed it.
|
Looks good to me. Not sure if the appveyor failures are related to this; seems unlikely... |
|
Is there anything left which is stalling a merge? |
|
Hi, looking at this again. I think it looks fine, but I'd rather take out the "exact version" string personally. It might be worth re-basing it to master since there's been some changes there. There should be a devchat tomorrow and I'll put this on the agenda :) |
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
==========================================
- Coverage 90.15% 89.83% -0.33%
==========================================
Files 144 144
Lines 27297 27100 -197
Branches 3926 3893 -33
==========================================
- Hits 24610 24344 -266
- Misses 1947 2026 +79
+ Partials 740 730 -10
Continue to review full report at Codecov.
|
|
I removed the version string and synced with master. |
Hi there,
this is a quick stab at ticket 1307 to add support for "HTTP OPTIONS" requests.
Cheers,
tpltnt