-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magicfolder backup files #448
Conversation
I still have no idea what the windows builder is sad about ... |
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
- Coverage 90.1% 90.06% -0.05%
==========================================
Files 144 144
Lines 27294 27301 +7
Branches 3926 3929 +3
==========================================
- Hits 24594 24589 -5
- Misses 1959 1967 +8
- Partials 741 745 +4
Continue to review full report at Codecov.
|
9ab7c2e
to
d6011fc
Compare
I don't know how to make codecov un-sad about the missing coverage; that commit did get built by travis -- perhaps that's when codecov was down and it didn't get the memo? |
Should be good to merge |
d6011fc
to
8e86c64
Compare
8e86c64
to
0ead5a6
Compare
0ead5a6
to
6c0c908
Compare
LGTM |
(Note: this is on top of the "multi-magic folder" branch, so ignore that commit -- and should be re-based once that's merged).
This fixes 2880 along with an integration test. You can trigger the bug the first time (and only this time) you re-start a client after a file has been added (and uploaded) in a magic-folder; then, an unnecessary
.backup
file will appear.