Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete invalid pidfile #450

Merged
merged 5 commits into from
Nov 20, 2017

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Nov 8, 2017

This is a re-based and resolved version of #441 -- had to re-org some of @lpirl's code due to changes on master

@meejah meejah force-pushed the delete-invalid-pidfile--lpirl branch 2 times, most recently from f42108f to aaa9fed Compare November 8, 2017 21:12
Conflicts:
	src/allmydata/scripts/startstop_node.py
	src/allmydata/test/cli/test_cli.py
@meejah meejah force-pushed the delete-invalid-pidfile--lpirl branch from aaa9fed to 50f8397 Compare November 8, 2017 21:49
@codecov-io
Copy link

codecov-io commented Nov 8, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@e89c99c). Click here to learn what that means.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #450   +/-   ##
=========================================
  Coverage          ?   89.83%           
=========================================
  Files             ?      144           
  Lines             ?    27120           
  Branches          ?     3897           
=========================================
  Hits              ?    24363           
  Misses            ?     2024           
  Partials          ?      733
Impacted Files Coverage Δ
src/allmydata/scripts/tahoe_stop.py 35.59% <57.14%> (ø)
src/allmydata/scripts/tahoe_daemonize.py 86.72% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e89c99c...50f8397. Read the comment docs.

@warner warner merged commit 50f8397 into tahoe-lafs:master Nov 20, 2017
@lpirl
Copy link
Contributor

lpirl commented Nov 20, 2017

Cheers!

@meejah meejah deleted the delete-invalid-pidfile--lpirl branch March 20, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants