Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set execute bit in default umask #458

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Jan 9, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 9, 2018

Codecov Report

Merging #458 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   90.07%   90.06%   -0.02%     
==========================================
  Files         144      144              
  Lines       27296    27296              
  Branches     3925     3925              
==========================================
- Hits        24586    24583       -3     
- Misses       1966     1968       +2     
- Partials      744      745       +1
Impacted Files Coverage Δ
src/allmydata/frontends/magic_folder.py 85.84% <100%> (ø) ⬆️
src/allmydata/mutable/servermap.py 93.7% <0%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187eb56...68783d8. Read the comment docs.

@tpltnt
Copy link
Contributor

tpltnt commented Jan 10, 2018

LGTM, data shouldn't be executable

@meejah meejah merged commit 7e39351 into tahoe-lafs:master Jan 11, 2018
@meejah meejah deleted the 2881.magic-folder-umask.0 branch January 11, 2018 22:55
@meejah meejah restored the 2881.magic-folder-umask.0 branch January 11, 2018 22:55
@meejah meejah deleted the 2881.magic-folder-umask.0 branch March 20, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants