need setuptools >= 28.8.0 for PEP440 #470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 93.03% 90.15% -2.89%
==========================================
Files 232 144 -88
Lines 58668 27344 -31324
Branches 7649 3929 -3720
==========================================
- Hits 54581 24651 -29930
+ Misses 3122 1951 -1171
+ Partials 965 742 -223
Continue to review full report at Codecov.
|
meejah
force-pushed
the
fix-lgtm
branch
4 times, most recently
from
e41ef6e
to
d003de4
Compare
(needs fixup, probably, just depending on latest setuptools)
|
looks good to me |
warner
changed the title
|
I'm going to land this, and see if it helps the LGTM baseline build. I'm not sure that 28.8.0 is strictly necessary (I think the "python_version <=.." clause in zfec's setup.py might be an "environment marker", in which case 20.8.1 is probably sufficient, but OTOH our |
|
although, note that the travis problem was with the "tox -e codechecks" build. I wonder if we need to explicitly upgrade setuptools in the tox config. The error only happened on the OS-X builder, and maybe it has an older version pre-installed. |
|
Reverted in 3bb4c97 because the change reliably breaks the OS X builder. |
The Travis OS-X worker has a very old setuptools-18.5 in /System. This is too old to understand several important setup.py keys like `python_requires`, and crashes when tryung to run the first invocation of tox (`tox -e codechecks`). I think tox is using the system python (with which `tox` was invoked) to run `setup.py egg_info` (to learn the dependencies), which gets the old system-installed setuptools. Ideally it'd use the python from the newly-created virtualenv, which would use whatever version of setuptools was bundled with the `virtualenv` package (probably newer, given that `virtualenv` itself should have been installed a moment earlier as a dependency of `tox`. I consider this a bug in Tox (tox-dev/tox#507), but the workaround is to configure Travis to install the most recent `setuptools` along with `tox`. refs tahoe-lafs#470
|
replaced by #473 |
No description provided.