Configurable storage path #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the [storage] section of the tahoe.cfg now there is a field 'storage_dir' where the path to the storage folder can be configured.
meejah
approved these changes
Mar 19, 2018
docs/configuration.rst
Outdated
| ``storage_dir = (string, optional)`` | ||
|
|
||
| This specifies a storing directory. | ||
|
|
There was a problem hiding this comment.
Maybe something like "This is where share files and other state pertaining to storage-servers will be kept".
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
+ Coverage 90.09% 90.11% +0.02%
==========================================
Files 144 144
Lines 27316 27321 +5
Branches 3926 3927 +1
==========================================
+ Hits 24609 24619 +10
+ Misses 1964 1959 -5
Partials 743 743
Continue to review full report at Codecov.
|
|
Wow, nice. I'm happy to see it merged. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2045 but does not completely resolve it.
This introduces a new configuration item to the
storagesection oftahoe.cfg,storage_dir. This item tells a storage node where in the filesystem the directory to use for share storage can be found.For example,
Now, instead of using
$BASEDIR/storagethis node will use/foo/bar.These changes were in part pulled out of #104 (which includes more changes for making more things configurable). I hope that pulling one specific feature out the chances of having it merged quickly are greater (and may even improve the chances of getting the rest of #104 merged).