Fix PyInstaller builds #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains a few small changes to fix PyInstaller frozen builds (which were recently broken in a few ways by changes introduced with `tahoe invite`, `tahoe daemonize`, and the addition of "setuptools >= 28.8.0" to setup_requires) and removes a couple of hacks that are no longer necessary to create working frozen tahoe executables with PyInstaller.
Closed
|
Cool, thanks. The "can we remove the |
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 90.21% 90.22% +<.01%
==========================================
Files 144 144
Lines 27446 27443 -3
Branches 3935 3934 -1
==========================================
Hits 24761 24761
+ Misses 1946 1945 -1
+ Partials 739 737 -2
Continue to review full report at Codecov.
|
|
Okay, it looks like we can indeed remove 'deps = .' now.. I was just able to create a working build without it (which was not the case a couple of weeks back). Should be good to go! |
crwood
added a commit
to crwood/tahoe-lafs
that referenced
this pull request
Jul 25, 2018
PR tahoe-lafs#482 (c850638) added setuptools to package_imports unconditionally; there is no need to append it (again) for frozen builds.
crwood
added a commit
to crwood/tahoe-lafs
that referenced
this pull request
Jul 26, 2018
PR tahoe-lafs#482 (c850638) added setuptools to package_imports unconditionally; there is no need to append it (again) for frozen builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a cleaner version of #471 :)