Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several tahoe status fixes #502

Merged
merged 1 commit into from
May 28, 2018

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented May 23, 2018

@meejah
Copy link
Contributor

meejah commented May 23, 2018

👍 LGTM, much cleaner! :) Please merge when builders are done

@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #502 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   90.13%   90.19%   +0.06%     
==========================================
  Files         144      144              
  Lines       27449    27465      +16     
  Branches     3941     3939       -2     
==========================================
+ Hits        24740    24771      +31     
+ Misses       1965     1955      -10     
+ Partials      744      739       -5
Impacted Files Coverage Δ
src/allmydata/scripts/tahoe_status.py 98.46% <100%> (+1.97%) ⬆️
src/allmydata/web/status.py 83.2% <100%> (+1.12%) ⬆️
src/allmydata/immutable/upload.py 95.53% <0%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c6552...2008450. Read the comment docs.

@exarkun
Copy link
Member Author

exarkun commented May 28, 2018

I think the slackware build failure is spurious. The failure has to do with some versioning issue:

twisted.trial.unittest.FailTest: We don't know our version, because this distribution didn't come with a _version.py and 'setup.py update_version' hasn't been run.

It looks like a test bug or an environment issue. It has nothing to do with tahoe status.

@exarkun exarkun merged commit 28a2e6e into tahoe-lafs:master May 28, 2018
@exarkun exarkun deleted the 2926.cli-status-exceptions branch May 28, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants