Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete pycrypto dependency #514

Merged

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Jul 19, 2018

Fixes ticket:2873

@codecov-io
Copy link

codecov-io commented Jul 19, 2018

Codecov Report

Merging #514 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   90.35%   90.01%   -0.35%     
==========================================
  Files         144      143       -1     
  Lines       27466    26267    -1199     
  Branches     3939     3699     -240     
==========================================
- Hits        24818    23643    -1175     
+ Misses       1924     1905      -19     
+ Partials      724      719       -5
Impacted Files Coverage Δ
src/allmydata/_auto_deps.py 100% <ø> (ø) ⬆️
src/allmydata/util/fileutil.py 50.56% <0%> (-5.65%) ⬇️
src/allmydata/scripts/tahoe_ls.py 82.46% <0%> (-5.2%) ⬇️
src/allmydata/util/iputil.py 64.7% <0%> (-3.37%) ⬇️
src/allmydata/immutable/downloader/share.py 92.82% <0%> (-2.47%) ⬇️
src/allmydata/dirnode.py 96.52% <0%> (-1.74%) ⬇️
src/allmydata/__init__.py 69.89% <0%> (-1.39%) ⬇️
src/allmydata/util/encodingutil.py 89% <0%> (-1.05%) ⬇️
src/allmydata/immutable/checker.py 87.43% <0%> (-1.03%) ⬇️
src/allmydata/mutable/publish.py 95.63% <0%> (-1.02%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844a5ff...0fb9e62. Read the comment docs.

@exarkun
Copy link
Member Author

exarkun commented Jul 24, 2018

Slackware failure is known and fixed by #515
Fedora failure is the same old test_system port collision failure.
No idea what the deal with the codecov failures are. This clearly does not remove any meaningful test coverage.

@exarkun
Copy link
Member Author

exarkun commented Jul 25, 2018

@MostAwesomeDude gave this a thumbs up on IRC.

@exarkun exarkun merged commit 1c24c64 into tahoe-lafs:master Jul 25, 2018
@exarkun exarkun deleted the 2873.remove-obsolete-pycrypto-dep branch July 25, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants