Avoid EADDRINUSE from allmydata.test.test_system.SystemTest #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`set_up_nodes` and `_set_up_nodes_2` now a little easier to understand
This endpoint is test-grade.
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
=========================================
- Coverage 90.2% 90.2% -0.01%
=========================================
Files 143 143
Lines 26267 26267
Branches 3699 3699
=========================================
- Hits 23695 23694 -1
Misses 1871 1871
- Partials 701 702 +1
Continue to review full report at Codecov.
|
|
Coverage difference looks spurious to me - reported line is in some time-sensitive web handling code that presumably has a race as to whether it is covered or not in any particular test run. |
|
Got a thumbs up from @MostAwesomeDude on IRC for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the use of
iptutil.allocate_tcp_portwhich is inherently race prone with a strategy employing pre-allocated sockets.Because the affected tests are complex and I had difficulty understanding how they work and what they are trying to accomplish, I also refactored them somewhat before starting. The changesets in this PR can largely be reviewed independently and doing so will make the significant changes I made to fix the issue (as opposed to refactoring) more readily apparent.
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2933