Convert the rest of Magic-Folder logging to Eliot #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it might even let us refactor someday
Supporting it with Eliot is challenging and we don't actually need it.
it bubbles out of _process and the caller logs it
vu3rdd
reviewed
Feb 27, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 85.45% 85.45% +<.01%
==========================================
Files 153 153
Lines 28310 28325 +15
Branches 4048 4050 +2
==========================================
+ Hits 24192 24205 +13
+ Misses 3435 3433 -2
- Partials 683 687 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: ticket:2977
This change is