updated all python files to use pep-3110 exception syntax for python3 compatibility #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heartsucker
force-pushed
the
3013-try-except-syntax
branch
from
38da086
to
b01676b
Compare
meejah
approved these changes
Mar 28, 2019
|
@heartsucker needs a rebase I guess ... |
|
Also circleci needs a kick (hung/non-responsive job?) |
heartsucker
force-pushed
the
3013-try-except-syntax
branch
from
b01676b
to
b64d660
Compare
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 86.12% 86.15% +0.02%
==========================================
Files 159 159
Lines 28666 28666
Branches 4080 4080
==========================================
+ Hits 24689 24696 +7
+ Misses 3273 3268 -5
+ Partials 704 702 -2
Continue to review full report at Codecov.
|
heartsucker
force-pushed
the
3013-try-except-syntax
branch
2 times, most recently
from
a91bba9
to
c5a8469
Compare
|
Hey @meejah I think this one can be merged since that codecov failure seems to be errant. |
heartsucker
force-pushed
the
3013-try-except-syntax
branch
2 times, most recently
from
10c6d13
to
4a1504b
Compare
heartsucker
force-pushed
the
3013-try-except-syntax
branch
from
4a1504b
to
0750dba
Compare
|
Hmmm, I wish github could tell me "what changed since I reviewed it last". Oh well :( Also, @heartsucker would it be possible for you to idle in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3013
This change is