Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some immutable upload eliot logging #594

Merged
merged 4 commits into from Apr 5, 2019

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Apr 3, 2019

Fixes: ticket:3023


This change is Reviewable

meejah
meejah previously requested changes Apr 4, 2019
Copy link
Contributor

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is sad about one import. Otherwise, 👍

@codecov-io
Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #594 into master will decrease coverage by 0.83%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   86.17%   85.33%   -0.84%     
==========================================
  Files         159      159              
  Lines       28654    29586     +932     
  Branches     4076     4422     +346     
==========================================
+ Hits        24692    25248     +556     
- Misses       3264     3608     +344     
- Partials      698      730      +32
Impacted Files Coverage Δ
src/allmydata/immutable/encode.py 95.95% <100%> (ø) ⬆️
src/allmydata/immutable/upload.py 95.63% <100%> (+0.1%) ⬆️
src/allmydata/windows/inotify.py 51.51% <0%> (-21.57%) ⬇️
src/allmydata/util/fake_inotify.py 96.92% <0%> (-0.91%) ⬇️
src/allmydata/frontends/sftpd.py 15.56% <0%> (+3.47%) ⬆️
src/allmydata/frontends/magic_folder.py 92.49% <0%> (+3.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8187a0...552459b. Read the comment docs.

@exarkun exarkun merged commit c0e9181 into master Apr 5, 2019
@exarkun exarkun deleted the 3023.some-immutable-upload-eliot-logging branch April 5, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants