updated string literal syntax for python3 compatibility #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exarkun
reviewed
Apr 18, 2019
src/allmydata/magicpath.py
Outdated
| import os.path | ||
|
|
||
| from allmydata.util.assertutil import precondition, _assert | ||
|
|
||
| def path2magic(path): | ||
| return re.sub(ur'[/@]', lambda m: {u'/': u'@_', u'@': u'@@'}[m.group(0)], path) | ||
| return re.sub(six.u(r'[/@]'), lambda m: {u'/': u'@_', u'@': u'@@'}[m.group(0)], path) |
There was a problem hiding this comment.
u"..." is supported from Python 3.3 onward. Do we need to change these?
There was a problem hiding this comment.
Ah. I see. u"..." works but ur"..." doesn't.
|
looks like legit failures on Windows at least? |
heartsucker
force-pushed
the
3028-string-literals
branch
from
b23c94c
to
05e0d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: ticket:3028
https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3028
This change is