Combined storage announcement #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of generating a sequence of announcements like:
- anonymous storage server announcement
- plugin 1 storage server announcement
- ...
- plugin N storage server announcement
The client now generates a single announcement like:
- anonymous storage server details
- storage-options
- plugin 1 storage server details
- ...
- plugin N storage server details
vu3rdd
reviewed
Jul 2, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
vu3rdd
reviewed
Jul 2, 2019
There was a problem hiding this comment.
Looks good to me.
Reviewable status:
vu3rdd
reviewed
Jul 2, 2019
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tahoe-lafs.org/trac/tahoe-lafs/ticket/3119
Note the target of the PR is integration/storage-economics as this is part of the larger storage economics milestone (https://tahoe-lafs.org/trac/tahoe-lafs/milestone/storage%20economics%20plugins).
This change is