Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "tahoe-ported.json" filename in the depgraph script #660

Merged
merged 6 commits into from
Sep 24, 2019

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Sep 16, 2019

Fixes: ticket:3256


This change is Reviewable

Just decline to push sometimes.

This way, if it's broken, you'll see that it's broken when working on your
branch.
@habnabit
Copy link
Contributor

Is this still under development? I didn't know how expected the builder failure is.

it's easier to version it alongside tahoe itself
This will go away when the Python 3 port is done.  It doesn't have to be ported.
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #660 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   89.12%   88.53%   -0.59%     
==========================================
  Files         165      165              
  Lines       28928    28936       +8     
  Branches     4102     4102              
==========================================
- Hits        25782    25619     -163     
- Misses       2384     2587     +203     
+ Partials      762      730      -32
Impacted Files Coverage Δ
src/allmydata/windows/inotify.py 0% <0%> (-72.52%) ⬇️
src/allmydata/windows/registry.py 0% <0%> (-47.62%) ⬇️
src/allmydata/windows/fixups.py 2.25% <0%> (-34.59%) ⬇️
src/allmydata/scripts/default_nodedir.py 50% <0%> (-14.29%) ⬇️
src/allmydata/util/fileutil.py 56.46% <0%> (-7.03%) ⬇️
src/allmydata/immutable/downloader/share.py 92.82% <0%> (-2.47%) ⬇️
src/allmydata/scripts/runner.py 73.38% <0%> (-1.44%) ⬇️
src/allmydata/immutable/checker.py 87.94% <0%> (-0.52%) ⬇️
src/allmydata/client.py 92% <0%> (-0.49%) ⬇️
src/allmydata/web/status.py 84.15% <0%> (-0.46%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bbe67...1738b9f. Read the comment docs.

@exarkun
Copy link
Member Author

exarkun commented Sep 17, 2019

Is this still under development? I didn't know how expected the builder failure is.

Not super expected! Fixed now though.

Copy link
Contributor

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

@exarkun exarkun merged commit 569a625 into master Sep 24, 2019
@exarkun exarkun deleted the 3256.tahoe-ported-filename branch September 24, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants