-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the "tahoe-ported.json" filename in the depgraph script #660
Conversation
Just decline to push sometimes. This way, if it's broken, you'll see that it's broken when working on your branch.
Is this still under development? I didn't know how expected the builder failure is. |
it's easier to version it alongside tahoe itself
This will go away when the Python 3 port is done. It doesn't have to be ported.
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 89.12% 88.53% -0.59%
==========================================
Files 165 165
Lines 28928 28936 +8
Branches 4102 4102
==========================================
- Hits 25782 25619 -163
- Misses 2384 2587 +203
+ Partials 762 730 -32
Continue to review full report at Codecov.
|
Not super expected! Fixed now though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 👍
Fixes: ticket:3256
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)