Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump 'tahoe backup' root dircap to stdout after completion if new --print-uri option present #76

Closed
wants to merge 4 commits into from
Closed

Dump 'tahoe backup' root dircap to stdout after completion if new --print-uri option present #76

wants to merge 4 commits into from

Conversation

pataquets
Copy link
Contributor

@pataquets pataquets commented Dec 14, 2013

Corresponding ticket at https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2135


This change is Reviewable

@remyroy
Copy link

remyroy commented Mar 19, 2014

Great code so far. I feel this would be quite useful for scripting backups.

There is still 2 failing backup related tests from this patch/pull request. The cli--tahoe-backup--dump-backup-dircap-stdout--tests branch from ​https://github.com/pataquets/tahoe-lafs/ seems to have some attempt at fixing those failing tests but they are still present.

There should also be an additional test in allmydata.test.test_cli.Backup to test this new command option.

Reassigning back the trac ticket to you for patch changes.

@tpltnt
Copy link
Contributor

tpltnt commented Apr 16, 2018

How should we proceed with this PR given the new plans for tahoe backup command?

@exarkun
Copy link
Member

exarkun commented Apr 16, 2018

If these are the plans you mean, I think it's probably still fine to add this feature. It's a pretty simple change. This implementation has conflicts but I guess it's the work of about 5 minutes to resolve them (otoh there is no test coverage included). So I don't see a reason to keep it out. I'll review if someone else wants to get the implementation in shape.

@exarkun
Copy link
Member

exarkun commented Aug 15, 2019

Over a year with no one taking me up on the review offer. I'm closing this for now. Anyone who feels like working on this should go for it. Re-open this PR or open a new one.

@exarkun exarkun closed this Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants