New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port allmydata.util.log to Python 3 #761
Conversation
… parent msgid logic so it's a little less broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just a couple minor comments inline, otherwise looks good. Please address and merge.
Looks like some legit test failures. |
More test failures :( |
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
+ Coverage 91.21% 91.23% +0.01%
==========================================
Files 156 155 -1
Lines 27235 27223 -12
Branches 3873 3871 -2
==========================================
- Hits 24842 24836 -6
+ Misses 1671 1665 -6
Partials 722 722
Continue to review full report at Codecov.
|
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3365