Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration codechecks #878

Merged
merged 3 commits into from Oct 29, 2020
Merged

integration codechecks #878

merged 3 commits into from Oct 29, 2020

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Oct 27, 2020

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #878 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #878    +/-   ##
=======================================
- Coverage      92%     92%    -0%     
=======================================
  Files         158     158            
  Lines       27487   27487            
  Branches     4113    4113            
=======================================
- Hits        25310   25177   -133     
- Misses       1500    1643   +143     
+ Partials      677     667    -10     
Impacted Files Coverage Δ
src/allmydata/windows/registry.py 0% <0%> (-48%) ⬇️
src/allmydata/windows/fixups.py 2% <0%> (-35%) ⬇️
src/allmydata/scripts/default_nodedir.py 53% <0%> (-20%) ⬇️
src/allmydata/util/fileutil.py 61% <0%> (-15%) ⬇️
src/allmydata/util/iputil.py 78% <0%> (-5%) ⬇️
src/allmydata/util/encodingutil.py 90% <0%> (-5%) ⬇️
src/allmydata/scripts/runner.py 72% <0%> (-2%) ⬇️
src/allmydata/client.py 93% <0%> (-<1%) ⬇️
src/allmydata/web/status.py 95% <0%> (ø)
src/allmydata/mutable/publish.py 97% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ee761...b9f7bca. Read the comment docs.

Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@exarkun exarkun merged commit 9a4df38 into master Oct 29, 2020
@exarkun exarkun deleted the 3490.integration-codechecks branch October 29, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants