WIP: mypy support

[jaraco]

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3399

[codecov]

Codecov Report

Merging #886 (b2fe574) into master (729a5a0) will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #886    +/-   ##
=======================================
- Coverage      92%     91%    -1%     
=======================================
  Files         158     158            
  Lines       27609   27609            
  Branches     4136    3933   -203     
=======================================
- Hits        25448   25258   -190     
- Misses       1487    1577    +90     
- Partials      674     774   +100     

Impacted Files	Coverage Δ
src/allmydata/util/dictutil.py	79% <0%> (-21%)	⬇️
src/allmydata/util/humanreadable.py	65% <0%> (-16%)	⬇️
src/allmydata/_monkeypatch.py	86% <0%> (-14%)	⬇️
src/allmydata/crypto/__init__.py	86% <0%> (-14%)	⬇️
src/allmydata/immutable/downloader/__init__.py	86% <0%> (-14%)	⬇️
src/allmydata/storage/common.py	88% <0%> (-12%)	⬇️
src/allmydata/crypto/error.py	89% <0%> (-11%)	⬇️
src/allmydata/util/_python3.py	89% <0%> (-11%)	⬇️
src/allmydata/util/assertutil.py	89% <0%> (-11%)	⬇️
src/allmydata/crypto/util.py	92% <0%> (-8%)	⬇️
... and 72 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729a5a0...4a1cbb8. Read the comment docs.

[sajith]

CircleCI is now failing with a "Could not find context dockerhub-auth" error. I think CircleCI would run if you create an empty "dockerhub-auth" context, and then re-run the workflow from start.

That is what I did anyway. Ideally our CircleCI configuration should be able to do unauthenticated pulls from DockerHub when DockerHub credentials are not available. I have not been able to figure out how to do that.

[jaraco]

Thanks sajith - I'm unfamiliar with creating dockerhub-auth contexts. Where would I create an empty one?

[sajith]

Log in at https://app.circleci.com, go to "organization settings" (this should be jaraco's organization settings, not tahoe-lafs' organization settings), and then click on the "create context" button to add a "dockerhub-auth" (without quotes, just to be sure!) context.

My understanding is that contexts are used to hold environment variables (such as Docker Hub credentials). For now our brand new "dockerhub-auth" context doesn't have to contain anything. At this point, if "re-run workflow" button is in fact able to re-run the workflow without that "could not find context" error, things should be good to go.

We should not have to go through these steps. I have filed 3541, but I don't know how to make contexts optional. I guess we could ask in CircleCI forums.

[wearpants]

CircleCI is now failing with a "Could not find context dockerhub-auth" error. I think CircleCI would run if you create an empty "dockerhub-auth" context, and then re-run the workflow from start.

I don't think this is related to mypy, is it? should probably be a separate issue / handle by somebody more familiar with infra (ie, probably not @jaraco)

[exarkun]

CircleCI is now failing with a "Could not find context dockerhub-auth" error. I think CircleCI would run if you create an empty "dockerhub-auth" context, and then re-run the workflow from start.

I don't think this is related to mypy, is it? should probably be a separate issue / handle by somebody more familiar with infra (ie, probably not @jaraco)

Correct, it's unrelated to MyPy but it's an issue with this PR because it causes most CI to be unrunnable. I think setting up the context is pretty easy and sajith gave instructions for doing so - but another solution is to switch to an in-repo branch (which will cause CI to use the in-repo context that already exists). I think @jaraco has access to do that.

The new context requirement is probably a development workflow regression that we should figure out. sajith filed a ticket for this - https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3541 - but I'm not sure yet how we're going to resolve it.

[exarkun]

I think @jaraco has access to do that.

Also, notably, only @jaraco can create the required context because it has to exist in his GitHub account settings.

[jaraco]

another solution is to switch to an in-repo branch

This approach sounds preferable. I'll plan to do that. Thanks.

[wearpants]

I think @jaraco has access to do that.

thanks for clarifying

[jaraco]

Superseded by #915