New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port test_introducer.py to Python 3 #905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks pretty good. Some comments inline. Here's N more:
- Do we have a best practice for strings that represent paths? The first two tests in
test_introducer
make two different choices - native string literal and unicode string literal. - in
test_introducer
there is aTooNewServer
that still uses native strings for itsVERSION
. It's used by a test that asserts some error has happened. I guess that test is trying to assert that the right error happened but since the realIntroducerService
has had itsVERSION
made into byte strings instead of native strings I wonder if that test is really working right.
I could not reproduce the Python 3 failure locally, but tried to fix it based on logs. Merged forward, hopefully correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good to me. Just one minor comment inline. Please address and then merge.
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
======================================
Coverage 92% 92%
======================================
Files 157 157
Lines 27419 27436 +17
Branches 4087 4093 +6
======================================
+ Hits 25188 25216 +28
+ Misses 1569 1560 -9
+ Partials 662 660 -2
Continue to review full report at Codecov.
|
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3514