Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mock usage from test_client #908

Merged
merged 4 commits into from Dec 5, 2020
Merged

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Nov 24, 2020

Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in test look equivalent to the prior revision to me.

Incidentally, I have been toying with GitHub's security scanning tools on my fork of Tahoe-LAFS. CodeQL generated three warnings:

https://github.com/sajith/tahoe-lafs/security/code-scanning?query=tool%3ACodeQL

Two of the warnings are about the use of mktemp(), but since that is in the test suite, I'm not sure we should worry. The other one is about creation of 1024-bit RSA keys, also possibly from the test suite, so I'm not sure those are worth worrying about too.

priv, pub = rsa.create_signing_keypair(1024)

priv, pub = rsa.create_signing_keypair(1024)

Just wanted to bring it to your attention because there's an mktemp() and an RSA key in this PR. :-)

@exarkun exarkun merged commit 81a6bfc into master Dec 5, 2020
@exarkun exarkun deleted the 3520.test_client-no-mock branch December 5, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants