Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _encode_tail_segment #952

Merged

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Jan 1, 2021

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #952 (3c20382) into master (7a504dd) will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #952   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         151     151           
  Lines       27179   27161   -18     
  Branches     4079    4078    -1     
======================================
- Hits        25038   25020   -18     
  Misses       1492    1492           
  Partials      649     649           
Impacted Files Coverage Δ
src/allmydata/immutable/encode.py 95% <100%> (-<1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a504dd...3c20382. Read the comment docs.

@exarkun exarkun requested a review from a team January 1, 2021 20:33
Copy link
Member

@sajith sajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement to me!

@exarkun exarkun merged commit baaa48a into tahoe-lafs:master Jan 4, 2021
@exarkun exarkun deleted the 3578.remove-encode_tail_segment branch January 4, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants