Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port more of test_system to Python3 #978

Merged
merged 7 commits into from
Feb 15, 2021
Merged

Port more of test_system to Python3 #978

merged 7 commits into from
Feb 15, 2021

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst commented Feb 3, 2021 •
edited

@itamarst
Copy link
Collaborator Author

itamarst commented Feb 4, 2021

This passes locally on Python 3, I don't understand :(

@itamarst itamarst changed the base branch from master to 517.add-client-plugin-config.1 February 10, 2021 19:21
@itamarst itamarst changed the base branch from 517.add-client-plugin-config.1 to master February 10, 2021 19:21
@itamarst itamarst requested a review from a team February 10, 2021 19:22
@itamarst
Copy link
Collaborator Author

itamarst commented Feb 10, 2021 •
edited

Due to screwup, this now also contains follow-up fixes for #976.

@itamarst itamarst mentioned this pull request Feb 12, 2021
Merged
exarkun
exarkun reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good. Please merge.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.04%) to 94.477% when pulling 06cd015 on 3606.test_system-web-python3 into e41ff1a on master.

@itamarst itamarst merged commit 2aec475 into master Feb 15, 2021
@itamarst itamarst deleted the 3606.test_system-web-python3 branch February 15, 2021 16:38
@chadwhitacre chadwhitacre mentioned this pull request Feb 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exarkun exarkun exarkun left review comments

Assignees
No one assigned
Labels
Python 3 Porting
Projects
None yet
Milestone
No milestone
3 participants
@itamarst @coveralls @exarkun