Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excess fill is occurring when pen is moved after starting a fill. #1238

Open
TomDoingArt opened this issue Oct 9, 2023 · 2 comments
Open
Labels
bug Something isn't working

Comments

@TomDoingArt
Copy link
Contributor

TomDoingArt commented Oct 9, 2023

Bug Description

Tahoma does the first fill, then after a split second does a second fill, filling all unclosed areas on the canvas.

Steps to reproduce

Situation: Using a stylus/pen and the Normal fill tool on a SmartRaster level with refer visible ticked.
Touch the screen to initiate a fill on a shape.
Lift the stylus and move it away from the area touched.
Tahoma does the first fill, then after a split second does a second fill, filling all unclosed areas on the canvas.

Relevant logs/screenshots

correct

Software Version

1.3.1

Software Version Information

No response

Operating System

Windows 10

Graphics Card

NVIDIA GTX 1080Ti

Drawing Tablet

XP Pen

@TomDoingArt TomDoingArt added the bug Something isn't working label Oct 9, 2023
@beeheemooth
Copy link
Contributor

I was getting the same behavior when using the Frame Range mode of the Fill Tool (Smart Raster). Filling occurred immediately, as if the mode was not turned on. Apparently the fill operation started and ended immediately in the current frame, as if there were two clicks. I thought my stylus was broken...

@manongjohn
Copy link
Collaborator

There are 2 issues going on here....

  1. There is a bug where when you do a normal mode click+drag refer visible fill on a Smart Raster level, will fill all empty pixels with the fill color when it encounters a different colored pixel. It produces the same result as the video shown in this issue.

  2. When tapping with a stylus and moving (without touching tablet), there is a TabletPress event followed by a bunch of TabletMove events before issuing a TabletRelease event. Usually the cursor position of the press and move event are close enough, but some tablets may produce points far away from each other.

In the case of the 2nd issue, the TabletPress immediately performs the 1st fill, but then the TabletMove events, treated as a drag, also try do to a fill where it thinks the cursor is. Normally these secondary fills fail because the pixel beneath the cursor has already been filled. However, coupled with the 1st issue it flood fills the cell.

Side note: Following a TabletRelease and MousePress event is issued and also attempts to do a fill operation, but usually fails because the pixel where it thinks the cursor is at already contains the fill color.

I have a fix for the 1st issue, which might help with both issues. If anything it will stop filling the entire cell and only impact the adjacent fillable region.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants