Fix potential pen-drag actions when tapping #1240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to the issue 2 noted in #1238 (comment).
Currently after a
TabletPress
event, the 1stTabletMove
event is processed and the internal timer skips any following move events for a very brief period. The problem this fixes is a simple pen tap can create a series ofTabletMove
events before theTabletRelease
event shows up. Depending on the tool, a pen-drag action could be triggered.In the case of the Fill tool, this can cause unwanted fills depending on where the pen detects the cursor immediately after the tap. I've modified the logic to ignore the 1st
TableMove
after aTabletPress
so there is time for theTabletRelease
to appear. If the release doesn't show up in time, assumed an intential pen drag, then the nextTabletMove
after the skip timer will take over as normal.I would have included this with #1239, however, this change can impact all tools and requires a bit more testing on all OSes to make sure nothing is broken.