Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential pen-drag actions when tapping #1240

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

manongjohn
Copy link
Collaborator

@manongjohn manongjohn commented Oct 11, 2023

This is in response to the issue 2 noted in #1238 (comment).

Currently after a TabletPress event, the 1st TabletMove event is processed and the internal timer skips any following move events for a very brief period. The problem this fixes is a simple pen tap can create a series of TabletMove events before the TabletRelease event shows up. Depending on the tool, a pen-drag action could be triggered.

In the case of the Fill tool, this can cause unwanted fills depending on where the pen detects the cursor immediately after the tap. I've modified the logic to ignore the 1st TableMove after a TabletPress so there is time for the TabletRelease to appear. If the release doesn't show up in time, assumed an intential pen drag, then the next TabletMove after the skip timer will take over as normal.

I would have included this with #1239, however, this change can impact all tools and requires a bit more testing on all OSes to make sure nothing is broken.

@manongjohn manongjohn added the 1.4 Included in Version 1.4 label Oct 11, 2023
@manongjohn
Copy link
Collaborator Author

I've tested this on Windows with my tablet and have heard from another Windows user and seems to be ok.

Any macOS users available to test pen dragging behavior in various tools?

I don't expect it to but just want to make sure this change doesn't cause other issues.

@manongjohn manongjohn merged commit 919d538 into tahoma2d:master Oct 19, 2023
4 checks passed
@artisteacher
Copy link
Contributor

Sorry for the late response!

It's working well for me on macOS. The only issue I've noticed so far, which may have been a thing before, is the Geometric Tool's arc and multi-arc modes. You click to create the start of the arc, click to create the end, and then can only click to create the top of the arc without the ability to adjust the location. It would be helpful to be able to do a click and drag for the top of the arc, so that you can adjust the apex of the arc on the fly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.4 Included in Version 1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants