Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixing multiple audio + rendering 32bit float sound #1150

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Fix mixing multiple audio + rendering 32bit float sound #1150

merged 1 commit into from
Apr 7, 2023

Conversation

manongjohn
Copy link
Collaborator

@manongjohn manongjohn commented Mar 30, 2023 •
edited

This PR fixes the following:

  • Updated ffmpeg sound rendering arguments to account for 32bit float to fix garbled/noisy rending.
  • Fixed issue with multiple audio not always mixing

@manongjohn manongjohn added the 1.4 Included in Version 1.4 label Mar 30, 2023
@artisteacher
Copy link
Contributor

So much better!

@manongjohn
Copy link
Collaborator Author

Removed an unnecessary change I made.

@manongjohn manongjohn changed the title Fix mixing different sound format types + rendering 32bit float sound Fix mixing multiple audio + rendering 32bit float sound Mar 30, 2023
@manongjohn manongjohn merged commit 9cfb593 into tahoma2d:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.4 Included in Version 1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manongjohn @artisteacher