Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon update followup #1190

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

manongjohn
Copy link
Collaborator

This is a minor followup to icon refactoring PR #1183 to do the following

  • Switches the last 2 parameters on createToolOptionsAction() to match the other create action functions.
    • This way the 1st 4 parameters matches OT and the remaining parameter is specific to T2D like the other functions.
  • Fixes a Linux/macOS issue in which some menu icons (i.e. fx node context menus) were still visible despite Show Menu Icons was not enabled.
    • Extended the logic that creates blank icons for Windows build to also work for Linux/macOS builds.

@manongjohn manongjohn added the 1.4 Included in Version 1.4 label Jul 13, 2023
@manongjohn manongjohn merged commit 976324c into tahoma2d:master Jul 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.4 Included in Version 1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant