Fix missing icon on different resolutions #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1193
This restores the logic to handle icon creation for different monitor resolutions when multiple monitors are in use. It was missed in the recently refactored icon logic.
As a result of restoring this logic, I had discovered an issue with icons always showing in menubars when multiple monitors with different resolutions were being used even though
Show Icons In Menuis disabled. This was caused by the change to setQt::AA_DontShowIconsInMenusfrom True to False whenShow Advanced Preferences and Optionswas implemented. The setting is now controlled byShow Icons In MenuPreference settings.