Fix macos library path reference #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems beyond some lib path changes, something else has changed in homebrew that is causing further problems with macOS builds. I noticed they updated QT 5.15.10 to 5.15.10.1 and I wonder whatever change was made is now causing some problems. |
|
Think I finally got it this time. Homebrew updated qt@5 which somehow impacted how |
|
Confirmed build is working again. ...and there was much rejoicing...yaaaaay... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of the macOS builds not fully starting, not even a splash screen, and just stops responding.
This is, in part, due to yet another set of missing frameworks and bad library path references caused by recent updates in Homebrew to webp and qt@5 packages. Coupled with the crash handler not able to handle the crash at immediate startup causes it to get stuck.
This fix will only address the missing frameworks and library path issue. Will needed to seprately handle why the crash handler is causing it to get stuck instead of crashing at start up
Will merge this once I verify the artifact successfully opens.