-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbolicate macOS and Linux crash logs for debugging #1210
Conversation
@artisteacher and/or other macOS users: Can you test this on something that crashes and post the results? I know when I download the artifact and run on a scene that crashes for me, it shows file/line numbers where it can. Prior artifacts didn't so I'm hopeful this will work and be helpful in the long run. |
Here's the result: |
Yes it is. Thanks! |
Revised logic and also updated Linux builds to be able to show filenames and line numbers. PR title and information updated to reflect the change. |
Here's the latest crash report, in case you need it: I do recommend removing the ability to close the crash report window on macOS in order to "resume the program". I've never been able to get back to T2D, it's just an immediate new crash after the dialog. It would be better for closing the window to really close the app. |
Thanks for retesting. It's working as intended. I will verify the Linux version is doing what I want it to do also. Will look at disabling the Resume functionality in a separate PR. |
I checked the Linux versions on a different VM and they work as expected. Interestingly the gcc version was more in line with the Windows and macOS backtraces. The clang version was either a line # off or didn't have a line number. At this point, I'll take what I can get. Going to merge this so any macOS/Linux users using the latest nightly can hopefully give useful crash reports. |
In order to provide filename/line number in backtrace information for macOS and Linux crash logs, this PR does the following:
As a result of including the DSYM files as part of the build, the overall footprint will increase by about 570 MB.
As a result of doing this, the overall footprint will increase by about 200 MB.