Fix SVG import from Browser #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengduLittleA
added a commit
to ChengduLittleA/opentoonz
that referenced
this pull request
Oct 4, 2023
SVGs are treated as PLI. Ignore the fIds lists. Ported from tahoma2d/tahoma2d#1230 Co-Authored-By: manongjohn <19245851+manongjohn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #1212.
This fixes a crash when loading SVG from the Browser. It was loading the SVGs without a palette because it was treating it as a normal image file rather than a PLI converted image and would crash when trying to display the image to screen.