Fix brush and eraser resizing #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes both the eraser and brush sizing but not the pump widget for vector selections, nor the camera name. |
|
Though maybe it is better for the camera name to be flipped - to keep as a visual indicator? |
|
The pump widget works much more reliably now! |
|
LGTM. Thanks for this fix! |
|
Thank you for the fix! |
|
Much appreciated! |
manongjohn
added
1.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1449.
By using mouse position in window coordinates, we get the correct delta when the viewer is rotated or flipped.