Skip to content

Commit

Permalink
Remove waiting for Loading Doggo component in E2E tests (#3541)
Browse files Browse the repository at this point in the history
### What

If the NFT page is loading really fast then the "loading doggo"
animation may not be visible for long enough to allow the e2e test to
catch that element. As the loader itself is not necessary for the rest
of the test let's omit testing for loader visibility, we can just test
if the loader disappeared.

Latest build:
[extension-builds-3541](https://github.com/tahowallet/extension/suites/14183949363/artifacts/795270419)
(as of Mon, 10 Jul 2023 14:09:54 GMT).
  • Loading branch information
Shadowfiend committed Jul 10, 2023
2 parents 7eaabfb + 67fa642 commit 2c9e248
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions e2e-tests/nfts.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,9 @@ test.describe("NFTs", () => {

await walletPageHelper.navigateTo("NFTs")

await expect(page.getByTestId("loading_doggo")).toBeVisible()

// Wait until load finishes
await expect(page.getByTestId("loading_doggo")).not.toBeVisible()

shouldInterceptRequests = false
})

Expand Down

0 comments on commit 2c9e248

Please sign in to comment.