Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Networks - Display a warning when attempting to add an already supported network #3211

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

hyphenized
Copy link
Contributor

@hyphenized hyphenized commented Mar 30, 2023

Closes #3207

Adds a warning to the new custom network confirmation screen

SUPPORT_CUSTOM_NETWORKS=true
SUPPORT_CUSTOM_RPCS=true

To Test

  • Head to chainlist.org, add a network then attempt to add it again.
  • On chainlist.org, attempt to add a builtin in network such as Ethereum

Latest build: extension-builds-3211 (as of Fri, 31 Mar 2023 10:02:21 GMT).

@hyphenized hyphenized self-assigned this Mar 30, 2023
Copy link
Contributor

@jagodarybacka jagodarybacka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅

Non-blocking: Can we push buttons in the footer to the bottom of the window as they are in Figma?

@jagodarybacka jagodarybacka merged commit ccb3a31 into main Mar 31, 2023
@jagodarybacka jagodarybacka deleted the existing-network-warning branch March 31, 2023 10:02
@kkosiorowska kkosiorowska mentioned this pull request Apr 5, 2023
jagodarybacka added a commit that referenced this pull request Apr 19, 2023
## What's Changed
* Token Balances - Fix base asset 0 balances not showing on custom
networks by @hyphenized in
#3208
* Custom RPCs - Segment custom networks in protocol list by @hyphenized
in #3206
* Run e2e tests also for PRs which modify feature flag by
@michalinacienciala in #3201
* Custom Networks - Display a warning when attempting to add an already
supported network by @hyphenized in
#3211
* Assign random colors to Chains in portfolio view. by @0xDaedalus in
#3204
* Change errors colors by @vvatom in
#3229
* Add analytics for Onboarding by @0xDaedalus in
#3215
* New copy for `Activity` by @kkosiorowska in
#3185
* Impersonate Metamask on kyberswap by @troggy in
#3239
* Add analytics event when connecting to a Dapp by @0xDaedalus in
#3235
* Add title to NFT market links by @hyphenized in
#3234
* Fix missing network icon on custom networks by @hyphenized in
#3241
* Fix broken links in CONTRIBUTING.md by @hakeemullahjan in
#3245
* Custom Networks - Update Protocol List Footer by @hyphenized in
#3244
* Disable network fees for custom networks. by @0xDaedalus in
#3203
* Add plumbing to allow for tokens to be imported via contract address
by @0xDaedalus in #3240
* Switch wallet to newly added network by @kkosiorowska in
#3184
* Remove sticky positioning from footer in network switcher by
@hyphenized in #3246
* Add custom chain analytics event by @0xDaedalus in
#3236
* More Analytics Events by @0xDaedalus in
#3251
* v0.29.0 by @0xDaedalus in
#3210

## New Contributors
* @troggy made their first contribution in
#3239
* @hakeemullahjan made their first contribution in
#3245

**Full Changelog**:
v0.29.0...v0.30.0

Latest build:
[extension-builds-3256](https://github.com/tahowallet/extension/suites/12048042958/artifacts/633528428)
(as of Wed, 05 Apr 2023 14:19:01 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message re: previously added network
2 participants