Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message re: previously added network #3207

Closed
mr-michael opened this issue Mar 28, 2023 · 0 comments · Fixed by #3211
Closed

Error message re: previously added network #3207

mr-michael opened this issue Mar 28, 2023 · 0 comments · Fixed by #3211
Assignees

Comments

@mr-michael
Copy link
Contributor

mr-michael commented Mar 28, 2023

If user attempts to add a network on Chainlist that is already added in Taho, display error message below.

The same message should display both for built-in networks as well as custom networks the user already added

Screenshot 2023-03-28 at 5 57 34 PM

https://www.figma.com/file/q8gfu9XTbYBF07KMnDCtsD/UI---Dark?node-id=17875-339145&t=5uLSqebakpDlcJpr-4

@mr-michael mr-michael added this to the Support bare RPC providers milestone Mar 28, 2023
@hyphenized hyphenized self-assigned this Mar 29, 2023
jagodarybacka added a commit that referenced this issue Mar 31, 2023
… supported network (#3211)

Closes #3207 

Adds a warning to the new custom network confirmation screen

```
SUPPORT_CUSTOM_NETWORKS=true
SUPPORT_CUSTOM_RPCS=true
```

## To Test
- [x] Head to chainlist.org, add a network then attempt to add it again.
- [x] On chainlist.org, attempt to add a builtin in network such as
Ethereum

Latest build:
[extension-builds-3211](https://github.com/tahowallet/extension/suites/11915544816/artifacts/623964814)
(as of Thu, 30 Mar 2023 12:17:05 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants