Monitoring XP drop #3679
Monitoring XP drop #3679
Conversation
ioay
force-pushed
the
monitoring_xp_drop
branch
from
7c9e96b
to
55d57ac
Compare
background/services/island/index.ts
Outdated
| const options = { | ||
| title: "Weekly XP distributed", | ||
| message: "Visit Subscape to see if you are eligible", | ||
| } |
There was a problem hiding this comment.
Does clicking on this notification have any impact? This was the goal of the callback part of the notification method, which would allow for a callback that opens Subscape (via browser.tabs.create, same as the Subscape logo link I believe).
…browser object change
ioay
force-pushed
the
monitoring_xp_drop
branch
from
56030ad
to
eede991
Compare
There was a problem hiding this comment.
Broad note: across the board, if we're using promises we should use async/await, not mix it in with .then.
I didn't get a chance to give this a full test drive with the switch back to browser WebExtension APIs. I think if we can confirm that permissions are prompted for properly (remember you have to uninstall/reinstall the extension for Chrome to reprompt for permission, possibly even change the extension id by installing it from a different location), the rest of the notes are non-blocking and we should land + cut the release.
|
|
ioay
force-pushed
the
monitoring_xp_drop
branch
from
61530a3
to
f76595b
Compare
| import { HOUR } from "../../constants" | ||
|
|
||
| const TAHO_ICON_URL = | ||
| "https://taho.xyz/icons/icon-144x144.png?v=41306c4d4e6795cdeaecc31bd794f68e" |
There was a problem hiding this comment.
Not blocking, but we should have an extension-local URL available for this I believe.
There was a problem hiding this comment.
Yep, we can do it, also for the wallet-connection-handler (the same approach).
|
Confirmed the notification permission is requested correctly, notification goes out, and toggle works as expected. |
|
Notably: I did not test attachment to the event, as that's not really doable without a lot of extra legwork. Code seems like it should do the thing, we'll find out in the wild 🤷 |
## What's Changed * v0.52.0 by @jagodarybacka in #3678 * Update release test list by @michalinacienciala in #3682 * Monitoring XP drop by @ioay in #3679 ## New Contributors * @ioay made their first contribution in #3679 **Full Changelog**: v0.52.0...v0.53.0 Latest build: [extension-builds-3690](https://github.com/tahowallet/extension/suites/18828582723/artifacts/1098086930) (as of Thu, 07 Dec 2023 03:26:04 GMT).
What
Showing notifications at the time of XP drop.
Prerequisite
The user allows the notification to be displayed.
Testing
Result
Important!
Do not merge! I'll do that, before merge we need to change notifiaction time threshold from 30sec(for testing purposes) to 24h:
NOTIFICATIONS_XP_DROP_THRESHOLD_MS_FOR_TESTING_PURPOSEtoNOTIFICATIONS_XP_DROP_THRESHOLD_MSLatest build: extension-builds-3679 (as of Wed, 06 Dec 2023 22:39:43 GMT).