Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.52.0 #3678

Merged
merged 1 commit into from
Nov 23, 2023
Merged

v0.52.0 #3678

merged 1 commit into from
Nov 23, 2023

Conversation

jagodarybacka
Copy link
Contributor

@jagodarybacka jagodarybacka commented Nov 22, 2023 •
edited by github-actions bot
Loading

What's Changed

New Contributors

Full Changelog: v0.51.0...v0.52.0

Latest build: extension-builds-3678 (as of Wed, 22 Nov 2023 14:53:11 GMT).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited by Shadowfiend
Loading

Release checklist

This release checklist should be performed before release is published.

  • dev tests should be performed by the dev team
  • if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
  • in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅

Dev tests

🚀 Version update

  • update from previous version with some accounts loaded

Manual tests

📨 Add account

  1. Add read-only account with ENS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  2. Add read-only account with UNS
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  3. Add read-only account with 0x address
    • check assets
    • check balance
    • check NFTs
    • check abilities (abilities should not be displayed)
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  4. Import account with a seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check seed phrase export
    • check private key export for first account
  5. Add another account from the same seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export for second account
  6. Add account with a Ledger
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check export options (export recovery phase and export private key should not be available)
  7. Create new wallet
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export
  8. Add account with private key
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export
  9. Add account with JSON keystore
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export

🗑️ Remove account

  1. Remove account by type
    • remove read-only account
    • remove address from imported account
    • remove Ledger account
    • remove account imported with private key
    • remove account imported with JSON keystore
    • remove selected account
    • remove not selected account
    • remove all accounts
  2. Remove account and check functionalities
    • add removed address from imported account
    • remove all addresses from imported account
    • check if NFTs are removed for removed accounts
    • check if abilities are removed for removed accounts
    • check if Portfolio page is updated for removed accounts

💌 Send base asset

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

🎁 Send ERC20

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

💸 Internal swap

  1. Ethereum mainnet
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website

📡 dApps connections

🎭 Sign in with Ethereum

🐶 Default wallet

  1. Default wallet setting turned OFF
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using MM
  2. Default wallet setting turned ON
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using Taho

⚙️ Settings

  • check hide balance under $2 option
  • check bug reports - export logs
  • check connected dapp - confirm you are able to disconnect from a dapp and connect again on different network

☀️ Abilities

  • check each filter option
  • delete ability
  • mark ability as completed

🌠 NFTs page

  1. NFTs page
    • browse NFTs
    • expand and collapse collection
    • check NFT preview
    • check Badges tab
  2. NFTs filters
    • check each sort type
    • disable account
    • disable collection

🦾 Flashbots

  1. Enable Flashbots in settings:
    • send/swap an asset & confirm trxn on Ethereum shows the Flashbots option with it auto-selected
    • confirm trxn is then sent through Flashbots
    • send/swap another asset deselect Flashbots option
    • confirm that trxn is not sent through Flashbots
  2. Check trxns on other networks
    • confirm Flashbots checkbox isn't shown at all
    • confirm trxn is not sent through Flashbots
  3. Disable Flashbots option in settings
    • send/swap an asset on Ethereum & confirm trxn shows without the Flashbots option
    • confirm trxn is not sent through Flashbots

@andreachapman
Copy link
Contributor

Testing notes: mostly everything looks good except one thing I noted below with disconnecting from the wallet. And then there were some I could not do but I made notes about them.

Potential Regression:
The quick disconnect from the wallet home screen isn't working, it's not showing up at all. I can go to Settings > Connected Websites and disconnect but from the home screen, I cannot see that option. Here's a video from 0.52.0 and then another from 0.51.0:

nodisconnect.mov
disconnect_on.51.mov

Things I wasn't able to do:

Couldn't do the ledger tests as I turned that back in to @Shadowfiend but we talked about that last week and decided it would be ok for someone else to handle that piece.

The spookyswap site gave me a warning that it's not secure so I skipped that one. Not sure what's happening but I didn't want to risk anything. I did then also see later that the domain was suspended.
Screenshot 2023-11-22 at 11 09 07 AM

Connect to MetaMask Test dApp & verify Personal Sign - wasn't working last release so skipped it (I think we might have said we'd remove this one because the way MM is doing that isn't the way we do it).

SIWE on login.xyz - known issue on their site that we discovered last week - wallet connects and says it's connected but their site isn't showing the "pick an emoji" that we expect after connecting.

Also note: swaps are still expensive on Ethereum mainnet so like with the last release, I did that test on Goerli (I had enough ETH to send assets but swapping was too much).

I don't have Abilities on any account like has been the case for a few releases so I skipped those.

For swaps on Optimism and Arbitrum: I ran out of enough ETH to finish those. For both, I had enough to Approve the Assets but then not enough to complete the swap. And I didn't have enough on testertesting.eth to bridge any from Ethereum to those networks.

Shadowfiend
Shadowfiend approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Shadowfiend Shadowfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I could not reproduce the issue with the quick disconnect in the top bar of the extension. Since we didn't touch anything that I immediately see could have caused this, I'm going to go ahead and ship this release.

@Shadowfiend Shadowfiend merged commit 4fe9acf into main Nov 23, 2023
13 checks passed
@Shadowfiend Shadowfiend deleted the release-0.52.0 branch November 23, 2023 03:43
@Shadowfiend Shadowfiend mentioned this pull request Dec 7, 2023
Merged
jagodarybacka added a commit that referenced this pull request Dec 14, 2023
@jagodarybacka
v0.53.0 (#3690)
99f77e6 
## What's Changed
* v0.52.0 by @jagodarybacka in
#3678
* Update release test list by @michalinacienciala in
#3682
* Monitoring XP drop by @ioay in
#3679

## New Contributors
* @ioay made their first contribution in
#3679

**Full Changelog**:
v0.52.0...v0.53.0

Latest build:
[extension-builds-3690](https://github.com/tahowallet/extension/suites/18828582723/artifacts/1098086930)
(as of Thu, 07 Dec 2023 03:26:04 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowfiend Shadowfiend Shadowfiend approved these changes

@andreachapman andreachapman Awaiting requested review from andreachapman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jagodarybacka @andreachapman @Shadowfiend