Show tooltips on hovering over icons with no labels #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagodarybacka
previously approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Looks good, just one thing - up to you and @VladUXUI what we want to do here
| @@ -804,6 +806,7 @@ | |||
| }, | |||
| "topMenu": { | |||
| "showCurrentDappConnection": "Show current website connection", | |||
| "currentDappConnection": "Current website connection", | |||
There was a problem hiding this comment.
I would change it to have it in one line - Dapp connection or something like that? cc @VladUXUI
|
Ok let's merge and fix later if needed |
jagodarybacka
approved these changes
Dec 20, 2023
Merged
xpaczka
added a commit
that referenced
this pull request
Dec 29, 2023
## What's Changed * Enable swaps on Sepolia testnet by @michalinacienciala in #3710 * Prevent read-only address submission when validating input by @xpaczka in #3705 * Support video avatars by @xpaczka in #3700 * Replace `customStyle` property with `style` by @xpaczka in #3715 * Show tooltips on hovering over icons with no labels by @xpaczka in #3711 * Minor UI issues by @xpaczka in #3716 * Fix hiding unverified assets by @jagodarybacka in #3708 * v0.54.0 by @xpaczka in #3706 * chore(ui): typo fix by @IssouChancla in #3717 * Switch e2e tests run on Goerli to Sepolia by @michalinacienciala in #3719 ## New Contributors * @xpaczka made their first contribution in #3705 * @IssouChancla made their first contribution in #3717 **Full Changelog**: v0.54.0...v0.55.0 Latest build: [extension-builds-3720](https://github.com/tahowallet/extension/suites/19343332470/artifacts/1136165985) (as of Wed, 27 Dec 2023 09:28:52 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3172
What has been done:
Added tooltips to the following icons:
Also updates
_localesfilesLatest build: extension-builds-3711 (as of Wed, 20 Dec 2023 12:10:19 GMT).