Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.54.0 #3706

Merged
merged 2 commits into from
Dec 22, 2023
Merged

v0.54.0 #3706

merged 2 commits into from
Dec 22, 2023

Conversation

xpaczka
Copy link
Contributor

@xpaczka xpaczka commented Dec 15, 2023

What's Changed

New Contributors

Full Changelog: v0.53.1...v0.54.0

Latest build: extension-builds-3706 (as of Fri, 22 Dec 2023 10:46:37 GMT).

Copy link

github-actions bot commented Dec 15, 2023

Release checklist

This release checklist should be performed before release is published.

  • dev tests should be performed by the dev team
  • if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
  • in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅


Dev tests

🚀 Version update

  • update from previous version with some accounts loaded

Manual tests

🤖 Items marked with this emoji are good candidates for automation (although
it does not mean that they all would be obsolete once automated).

📝 Background processes

  1. During execution of other tests on the list monitor extension's DevTools
    • check that there are no problematic errors in the Console tab
    • check the number of requests on the Network tab (the number shouldn't
      increase significantly in periods of user inactivity)

📨 Add account

  1. Add read-only account with ENS
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities (abilities should not be displayed) 🤖
    • check activities
    • check portfolio page 🤖
    • check export options (export recovery phrase and export private key should not be available) 🤖
  2. Add read-only account with UNS
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities (abilities should not be displayed) 🤖
    • check activities
    • check portfolio page 🤖
    • check export options (export recovery phrase and export private key should not be available) 🤖
  3. Add read-only account with 0x address
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities (abilities should not be displayed) 🤖
    • check activities
    • check portfolio page 🤖
    • check export options (export recovery phrse and export private key should not be available) 🤖
  4. Import account with a seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check seed phrase export
    • check private key export for first account 🤖
  5. Add another account from the same seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export for second account 🤖
  6. Add account with a Ledger
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check export options (export recovery phrase and export private key should not be available)
  7. Create new wallet
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities 🤖
    • check activities 🤖
    • check portfolio page 🤖
    • check private key export 🤖
  8. Add account with private key
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export 🤖
  9. Add account with JSON keystore
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities 🤖
    • check activities 🤖
    • check portfolio page 🤖
    • check private key export 🤖

🗑️ Remove account

  1. Remove account by type
    • remove read-only account 🤖
    • remove address from imported account 🤖
    • remove Ledger account
    • remove account imported with private key 🤖
    • remove account imported with JSON keystore 🤖
    • remove selected account 🤖
    • remove not selected account 🤖
    • remove all accounts 🤖
  2. Remove account and check functionalities
    • add removed address from imported account 🤖
    • remove all addresses from imported account 🤖
    • check if NFTs are removed for removed accounts 🤖
    • check if abilities are removed for removed accounts 🤖
    • check if Portfolio page is updated for removed accounts 🤖

💌 Send base asset

When there are no changes touching sending txs in the release, only one base
asset send transaction on some mainnet chain is required to be tested. Make sure
it's on different chain than the ERC-20 asset send transaction.
When there are changes in the release that may affect transactions, lets test
everything from the list.

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

🎁 Send ERC20

When there are no changes touching sending txs in the release, only one ERC20
send transaction on some mainnet chain is required to be tested. Make sure it's
on different chain than the base asset send transaction.
When there are changes in the release that may affect transactions, lets test
everything from the list.

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

💸 Internal swap

When there are no changes touching swaps in the release, only one swap on some
mainnet chain is required to be tested.
When there are changes in the release that may affect swaps, lets test
everything from the list.

  1. Ethereum mainnet
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign (if expensive, can be executed on testnet)
    • check transaction on scan website
  2. Polygon
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website

📡 dApps connections

When there are no changes touching connectivity to dApps, it's enough to do only
a few reandom tests from the list.

🎭 Sign in with Ethereum

🐶 Default wallet

  1. Default wallet setting turned OFF
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using MM
  2. Default wallet setting turned ON
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using Taho

⚙️ Settings

  • check hide balance under $2 option 🤖
  • check bug reports - export logs 🤖
  • check connected dapp - confirm you are able to disconnect from a dapp and connect again on different network 🤖

☀️ Abilities 🔴 #3707

  • check each filter option 🤖
  • delete ability 🤖
  • mark ability as completed 🤖

🌠 NFTs page

  1. NFTs page
    • browse NFTs 🤖
    • expand and collapse collection 🤖
    • check NFT preview 🤖
    • check Badges tab 🤖
  2. NFTs filters
    • check each sort type 🤖
    • disable account 🤖
    • disable collection 🤖

🦾 Flashbots

  1. Enable Flashbots in settings:
    • send/swap an asset & confirm trxn on Ethereum shows the Flashbots option with it auto-selected 🤖
    • confirm trxn is then sent through Flashbots 🤖 (send only)
    • send/swap another asset deselect Flashbots option
    • confirm that trxn is not sent through Flashbots 🤖 (send only)
  2. Check trxns on other networks
    • confirm Flashbots checkbox isn't shown at all 🤖
    • confirm trxn is not sent through Flashbots 🤖
  3. Disable Flashbots option in settings
    • send/swap an asset on Ethereum & confirm trxn shows without the Flashbots option 🤖
    • confirm trxn is not sent through Flashbots 🤖 (send only)

@michalinacienciala
Copy link
Contributor

There is a problem with abilities: #3707. But it's not related to the release (checked also on 0.53.0).

Copy link
Contributor

@michalinacienciala michalinacienciala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some abnormalities observe during testing, but nothing blocking the release. Approving.

@xpaczka xpaczka merged commit 6c97aef into main Dec 22, 2023
6 checks passed
@xpaczka xpaczka deleted the release-0.54.0 branch December 22, 2023 10:38
@xpaczka xpaczka mentioned this pull request Dec 27, 2023
xpaczka added a commit that referenced this pull request Dec 29, 2023
## What's Changed
* Enable swaps on Sepolia testnet by @michalinacienciala in
#3710
* Prevent read-only address submission when validating input by @xpaczka
in #3705
* Support video avatars by @xpaczka in
#3700
* Replace `customStyle` property with `style` by @xpaczka in
#3715
* Show tooltips on hovering over icons with no labels by @xpaczka in
#3711
* Minor UI issues by @xpaczka in
#3716
* Fix hiding unverified assets by @jagodarybacka in
#3708
* v0.54.0 by @xpaczka in
#3706
* chore(ui): typo fix by @IssouChancla in
#3717
* Switch e2e tests run on Goerli to Sepolia by @michalinacienciala in
#3719

## New Contributors
* @xpaczka made their first contribution in
#3705
* @IssouChancla made their first contribution in
#3717

**Full Changelog**:
v0.54.0...v0.55.0

Latest build:
[extension-builds-3720](https://github.com/tahowallet/extension/suites/19343332470/artifacts/1136165985)
(as of Wed, 27 Dec 2023 09:28:52 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants