[cuda] [bug] Fix CUDA runtime crash #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1271 +/- ##
=======================================
Coverage 65.65% 65.65%
=======================================
Files 36 36
Lines 5066 5066
Branches 928 928
=======================================
Hits 3326 3326
Misses 1569 1569
Partials 171 171 Continue to review full report at Codecov.
|
archibate
approved these changes
Jun 18, 2020
Comment on lines
-277
to
-279
| } else { | ||
| runtime->call<void *, void *>("LLVMRuntime_set_profiler", llvm_runtime, | ||
| nullptr); |
There was a problem hiding this comment.
Would you tell me why removing this make things work?
There was a problem hiding this comment.
It's just because on certain platforms LLVMRuntime_set_profiler is not found. Maybe due to name mangling. I haven't got a chance to figure it out.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = close #1266
[Click here for the format server]