Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cuda] [bug] Fix CUDA runtime crash #1271

Merged
merged 1 commit into from Jun 18, 2020
Merged

[cuda] [bug] Fix CUDA runtime crash #1271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions taichi/program/program.cpp
View file
Open in desktop
Expand Up @@ -274,9 +274,6 @@ void Program::initialize_runtime_system(StructCompiler *scomp) {
(void *)&KernelProfilerBase::profiler_start);
runtime->call<void *, void *>("LLVMRuntime_set_profiler_stop", llvm_runtime,
(void *)&KernelProfilerBase::profiler_stop);
} else {
runtime->call<void *, void *>("LLVMRuntime_set_profiler", llvm_runtime,
nullptr);
Comment on lines -277 to -279
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you tell me why removing this make things work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just because on certain platforms LLVMRuntime_set_profiler is not found. Maybe due to name mangling. I haven't got a chance to figure it out.

}
}

Expand Down