Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metal] Pass kernel name and is_evalutator to the runtime #1430

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Jul 7, 2020

I hope this will make things easier?

Related issue = #1428

[Click here for the format server]


@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1430 into master will decrease coverage by 0.04%.
The diff coverage is 62.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
- Coverage   85.21%   85.16%   -0.05%     
==========================================
  Files          20       20              
  Lines        3449     3451       +2     
  Branches      631      632       +1     
==========================================
  Hits         2939     2939              
- Misses        382      383       +1     
- Partials      128      129       +1     
Impacted Files Coverage Δ
python/taichi/lang/matrix.py 91.33% <62.96%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfe530...47dbc0b. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I'll merge #1428 with this.

@yuanming-hu yuanming-hu merged commit c75e5ed into taichi-dev:master Jul 7, 2020
@k-ye k-ye deleted the mtl branch July 7, 2020 14:42
@FantasyVR FantasyVR mentioned this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants