Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opt] Improve aliasing analysis for SNodes with trailing bits #1657

Merged
merged 4 commits into from
Aug 8, 2020

Conversation

xumingkuan
Copy link
Collaborator

@xumingkuan xumingkuan commented Aug 7, 2020

Related issue = #1558 #656
Replaces #1627
Benchmark(#stmts): unchanged.

[Click here for the format server]


@xumingkuan xumingkuan changed the title [Opt] Improve aliasing analysis [Opt] Improve aliasing analysis for SNodes with trailing bits Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #1657 into master will decrease coverage by 0.19%.
The diff coverage is 32.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1657      +/-   ##
==========================================
- Coverage   44.40%   44.21%   -0.20%     
==========================================
  Files          41       41              
  Lines        5875     5892      +17     
  Branches     1022     1023       +1     
==========================================
- Hits         2609     2605       -4     
- Misses       3117     3138      +21     
  Partials      149      149              
Impacted Files Coverage Δ
python/taichi/lang/meta.py 62.85% <0.00%> (-1.85%) ⬇️
python/taichi/misc/gui.py 0.00% <0.00%> (ø)
python/taichi/lang/snode.py 66.08% <25.00%> (-1.49%) ⬇️
python/taichi/lang/__init__.py 53.76% <50.00%> (-0.99%) ⬇️
python/taichi/lang/matrix.py 67.52% <50.00%> (+0.04%) ⬆️
python/taichi/lang/expr.py 63.42% <80.00%> (-0.37%) ⬇️
python/taichi/lang/impl.py 65.80% <100.00%> (ø)
python/taichi/lang/ops.py 43.62% <100.00%> (ø)
python/taichi/main.py 23.73% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6bc8d6...09072f0. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me in general. Just a few minor issues. Please merge after they are resolved.

taichi/analysis/alias_analysis.cpp Outdated Show resolved Hide resolved
taichi/analysis/value_diff.cpp Outdated Show resolved Hide resolved
taichi/analysis/value_diff.cpp Outdated Show resolved Hide resolved
@xumingkuan xumingkuan merged commit b85b3a5 into taichi-dev:master Aug 8, 2020
@xumingkuan xumingkuan deleted the alias2 branch August 8, 2020 07:56
@yuanming-hu yuanming-hu mentioned this pull request Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants