Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ir] Fix irpass::analysis::clone on TLS/BLS prologue/epilogue #1811

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

yuanming-hu
Copy link
Member

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #1811 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
+ Coverage   64.12%   64.25%   +0.13%     
==========================================
  Files          19       19              
  Lines        3688     3710      +22     
  Branches      696      700       +4     
==========================================
+ Hits         2365     2384      +19     
- Misses       1197     1200       +3     
  Partials      126      126              
Impacted Files Coverage Δ
python/taichi/lang/impl.py 67.31% <0.00%> (-0.01%) ⬇️
python/taichi/lang/transformer.py 81.88% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f1a5d...8537611. Read the comment docs.

@archibate
Copy link
Collaborator

This branch is out-of-date with the base branch

What happened to our project settings these time? If you did this, could you revert? I don't think it's reducing possible error at all.. Instead, it increase the difficulty of workflow for maintainers.

@yuanming-hu yuanming-hu requested a review from k-ye August 30, 2020 15:54
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@k-ye k-ye merged commit 07f407d into taichi-dev:master Aug 31, 2020
@yuanming-hu yuanming-hu mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants