[async] Highlight user kernels in the DOT graph, allows configuring rankdir #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
+ Coverage 43.25% 44.21% +0.95%
==========================================
Files 44 44
Lines 6320 6111 -209
Branches 1092 1092
==========================================
- Hits 2734 2702 -32
+ Misses 3416 3240 -176
+ Partials 170 169 -1
Continue to review full report at Codecov.
|
xumingkuan
approved these changes
Sep 13, 2020
| @@ -4,14 +4,13 @@ | |||
| #include <unordered_set> | |||
|
|
|||
| #include "taichi/ir/snode.h" | |||
| #include "taichi/ir/statements.h" | |||
There was a problem hiding this comment.
taichi/ir/statements.h includes taichi/ir/ir.h...
There was a problem hiding this comment.
True... Unfortunately i need this to pull in OffloadedStmt::TaskType
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
I'll look into more on how we can better represent the nodes/edges..
Related issue = #1855
[Click here for the format server]