[async] Cache demote_activation #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumingkuan
commented
Sep 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #1889 +/- ##
==========================================
- Coverage 43.80% 43.80% -0.01%
==========================================
Files 45 45
Lines 6168 6171 +3
Branches 1097 1097
==========================================
+ Hits 2702 2703 +1
- Misses 3297 3299 +2
Partials 169 169
Continue to review full report at Codecov.
|
k-ye
reviewed
Sep 24, 2020
yuanming-hu
approved these changes
Sep 24, 2020
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
xumingkuan
commented
Sep 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #742
(Not sure if it's better to move
IRBankto a separate file... This class is handling more and more stuff.)[Click here for the format server]