Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move IRBank to a separate file #1897

Merged
merged 3 commits into from Sep 26, 2020

Conversation

xumingkuan
Copy link
Collaborator

Related issue = #1889 (comment)

This PR only moves IRBank to ir_bank.h and moves some function implementations to their corresponding .cpp files.

[Click here for the format server]


Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #1897 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1897   +/-   ##
=======================================
  Coverage   43.81%   43.81%           
=======================================
  Files          45       45           
  Lines        6174     6174           
  Branches     1097     1097           
=======================================
  Hits         2705     2705           
  Misses       3300     3300           
  Partials      169      169           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f59d0...6452d41. Read the comment docs.

@xumingkuan xumingkuan merged commit bccc955 into taichi-dev:master Sep 26, 2020
@yuanming-hu yuanming-hu mentioned this pull request Sep 26, 2020
@xumingkuan xumingkuan deleted the bank branch October 12, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants