Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] meta: s/alone/along/ #2616

Merged
merged 1 commit into from Aug 4, 2021
Merged

[doc] meta: s/alone/along/ #2616

merged 1 commit into from Aug 4, 2021

Conversation

EricCousineau-TRI
Copy link
Contributor

Minor doc fix; I believe intent here was "Size along dimension"

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@k-ye k-ye changed the title docs meta: s/alone/along/ [doc] meta: s/alone/along/ Jul 31, 2021
@k-ye
Copy link
Member

k-ye commented Jul 31, 2021

Thanks! Would you sign the CLA so that we can merge this :-)

ljcc0930
ljcc0930 previously approved these changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@ljcc0930 ljcc0930 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EricCousineau-TRI
Copy link
Contributor Author

Thanks! Would you sign the CLA so that we can merge this :-)

Will let you know once I have the go-ahead - thanks!
(if that's too slow, please feel free to re-author the commit!)

@k-ye k-ye dismissed ljcc0930’s stale review August 3, 2021 02:09

Blocked by CLA

@EricCousineau-TRI
Copy link
Contributor Author

Signed! Just reformatted my commit to match PR title; hopefully that fixes the CI check?

@k-ye
Copy link
Member

k-ye commented Aug 4, 2021

match PR title; hopefully that fixes the CI check?

Thanks! Don't worry too much about the title check :-)

@k-ye k-ye merged commit 75f9de1 into taichi-dev:master Aug 4, 2021
@Leonz5288 Leonz5288 mentioned this pull request Aug 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

@ljcc0930 ljcc0930 ljcc0930 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EricCousineau-TRI @CLAassistant @k-ye @ljcc0930