Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Add ti.round op #3541

Merged
merged 6 commits into from Nov 23, 2021
Merged

[Lang] Add ti.round op #3541

merged 6 commits into from Nov 23, 2021

Conversation

gaoxinge
Copy link
Contributor

Related issue = #

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: c0968b7

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/619baea28aa48e0008167069

😎 Browse the preview: https://deploy-preview-3541--jovial-fermat-aa59dc.netlify.app

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your work! A little suggestion: could you also add the op in backends/vulkan/codegen_vulkan.cpp and backends/metal/data_types.cpp?

python/taichi/lang/ops.py Outdated Show resolved Hide resolved
@gaoxinge
Copy link
Contributor Author

@strongoier I have add round op code in backends/vulkan/codegen_vulkan.cpp (follow by link) and backends/metal/data_types.cpp, but I'm not sure whether it will work properly.

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your modifications look pretty good to me. To verify your modifications, you can remove

@ti.test(exclude=[ti.vulkan])
and see if CI can pass. However, our CI seems buggy on your PR (#3568), and you may need to wait for a fix for that. Sorry about that.

@strongoier
Copy link
Contributor

Now our CI is fixed. You could try my comment above now.

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@strongoier strongoier merged commit cbdf5dd into taichi-dev:master Nov 23, 2021
@gaoxinge gaoxinge deleted the add-round-op branch November 23, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants