New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lang] Add ti.round op #3541
[Lang] Add ti.round op #3541
Conversation
✔️ Deploy Preview for jovial-fermat-aa59dc ready! 🔨 Explore the source changes: c0968b7 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/619baea28aa48e0008167069 😎 Browse the preview: https://deploy-preview-3541--jovial-fermat-aa59dc.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for your work! A little suggestion: could you also add the op in backends/vulkan/codegen_vulkan.cpp
and backends/metal/data_types.cpp
?
@strongoier I have add round op code in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your modifications look pretty good to me. To verify your modifications, you can remove
taichi/tests/python/test_element_wise.py
Line 245 in 17a0a11
@ti.test(exclude=[ti.vulkan]) |
Now our CI is fixed. You could try my comment above now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Related issue = #